Commit a13bd6f3 authored by Ricardo B. Marliere's avatar Ricardo B. Marliere Committed by Greg Kroah-Hartman
Browse files

greybus: move is_gb_* functions out of greybus.h 



The functions below are only used within the context of
drivers/greybus/core.c, so move them all into core and drop their 'inline'
specifiers:

is_gb_host_device(), is_gb_module(), is_gb_interface(), is_gb_control(),
is_gb_bundle() and is_gb_svc().

Suggested-by: default avatarAlex Elder <elder@ieee.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatar"Ricardo B. Marliere" <ricardo@marliere.net>
Reviewed-by: default avatarAlex Elder <elder@linaro.org>
Link: https://lore.kernel.org/r/20240226-device_cleanup-greybus2-v1-1-5f7d1161e684@marliere.net


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3bd29138

drivers/greybus/core.c

+30 −0
Original line number Diff line number Diff line
@@ -27,6 +27,36 @@ int greybus_disabled(void) 
}

EXPORT_SYMBOL_GPL(greybus_disabled);



static int is_gb_host_device(const struct device *dev)

{

	return dev->type == &greybus_hd_type;

}



static int is_gb_module(const struct device *dev)

{

	return dev->type == &greybus_module_type;

}



static int is_gb_interface(const struct device *dev)

{

	return dev->type == &greybus_interface_type;

}



static int is_gb_control(const struct device *dev)

{

	return dev->type == &greybus_control_type;

}



static int is_gb_bundle(const struct device *dev)

{

	return dev->type == &greybus_bundle_type;

}



static int is_gb_svc(const struct device *dev)

{

	return dev->type == &greybus_svc_type;

}



static bool greybus_match_one_id(struct gb_bundle *bundle,

				 const struct greybus_bundle_id *id)

{

include/linux/greybus.h

+0 −30
Original line number Diff line number Diff line
@@ -113,36 +113,6 @@ extern const struct device_type greybus_control_type; 
extern const struct device_type greybus_bundle_type;

extern const struct device_type greybus_svc_type;



static inline int is_gb_host_device(const struct device *dev)

{

	return dev->type == &greybus_hd_type;

}



static inline int is_gb_module(const struct device *dev)

{

	return dev->type == &greybus_module_type;

}



static inline int is_gb_interface(const struct device *dev)

{

	return dev->type == &greybus_interface_type;

}



static inline int is_gb_control(const struct device *dev)

{

	return dev->type == &greybus_control_type;

}



static inline int is_gb_bundle(const struct device *dev)

{

	return dev->type == &greybus_bundle_type;

}



static inline int is_gb_svc(const struct device *dev)

{

	return dev->type == &greybus_svc_type;

}



static inline bool cport_id_valid(struct gb_host_device *hd, u16 cport_id)

{

	return cport_id != CPORT_ID_BAD && cport_id < hd->num_cports;