Commit a15b5379 authored by Zhi Wang's avatar Zhi Wang Committed by Danilo Krummrich
Browse files

drm/nouveau: remove unused param repc in *rm_alloc_push() 



The user of *rm_alloc_push() always pass 0 in repc.

Remove unused param repc since no user actually uses it.

No functional change is intended.

Signed-off-by: default avatarZhi Wang <zhiw@nvidia.com>
Signed-off-by: default avatarDanilo Krummrich <dakr@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20250124182958.2040494-5-zhiw@nvidia.com
parent 2c6a79af

drivers/gpu/drm/nouveau/include/nvkm/subdev/gsp.h

+4 −4
Original line number Diff line number Diff line
@@ -196,7 +196,7 @@ struct nvkm_gsp { 
		void (*rm_ctrl_done)(struct nvkm_gsp_object *, void *repv);



		void *(*rm_alloc_get)(struct nvkm_gsp_object *, u32 oclass, u32 argc);

		void *(*rm_alloc_push)(struct nvkm_gsp_object *, void *argv, u32 repc);

		void *(*rm_alloc_push)(struct nvkm_gsp_object *, void *argv);

		void (*rm_alloc_done)(struct nvkm_gsp_object *, void *repv);



		int (*rm_free)(struct nvkm_gsp_object *);
@@ -353,9 +353,9 @@ nvkm_gsp_rm_alloc_get(struct nvkm_gsp_object *parent, u32 handle, u32 oclass, u3 
}



static inline void *

nvkm_gsp_rm_alloc_push(struct nvkm_gsp_object *object, void *argv, u32 repc)

nvkm_gsp_rm_alloc_push(struct nvkm_gsp_object *object, void *argv)

{

	void *repv = object->client->gsp->rm->rm_alloc_push(object, argv, repc);

	void *repv = object->client->gsp->rm->rm_alloc_push(object, argv);



	if (IS_ERR(repv))

		object->client = NULL;
@@ -366,7 +366,7 @@ nvkm_gsp_rm_alloc_push(struct nvkm_gsp_object *object, void *argv, u32 repc) 
static inline int

nvkm_gsp_rm_alloc_wr(struct nvkm_gsp_object *object, void *argv)

{

	void *repv = nvkm_gsp_rm_alloc_push(object, argv, 0);

	void *repv = nvkm_gsp_rm_alloc_push(object, argv);



	if (IS_ERR(repv))

		return PTR_ERR(repv);

drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c

+3 −5
Original line number Diff line number Diff line
@@ -647,13 +647,13 @@ r535_gsp_rpc_rm_alloc_done(struct nvkm_gsp_object *object, void *repv) 
}



static void *

r535_gsp_rpc_rm_alloc_push(struct nvkm_gsp_object *object, void *argv, u32 repc)

r535_gsp_rpc_rm_alloc_push(struct nvkm_gsp_object *object, void *argv)

{

	rpc_gsp_rm_alloc_v03_00 *rpc = container_of(argv, typeof(*rpc), params);

	struct nvkm_gsp *gsp = object->client->gsp;

	void *ret;

	void *ret = NULL;



	rpc = nvkm_gsp_rpc_push(gsp, rpc, true, sizeof(*rpc) + repc);

	rpc = nvkm_gsp_rpc_push(gsp, rpc, true, sizeof(*rpc));

	if (IS_ERR_OR_NULL(rpc))

		return rpc;
@@ -661,8 +661,6 @@ r535_gsp_rpc_rm_alloc_push(struct nvkm_gsp_object *object, void *argv, u32 repc) 
		ret = ERR_PTR(r535_rpc_status_to_errno(rpc->status));

		if (PTR_ERR(ret) != -EAGAIN && PTR_ERR(ret) != -EBUSY)

			nvkm_error(&gsp->subdev, "RM_ALLOC: 0x%x\n", rpc->status);

	} else {

		ret = repc ? rpc->params : NULL;

	}



	nvkm_gsp_rpc_done(gsp, rpc);