Commit a175ee82 authored by Thorsten Blum's avatar Thorsten Blum Committed by Jens Axboe
Browse files

block: use sysfs_emit in sysfs show functions 



Replace sprintf() with sysfs_emit() in sysfs show functions.
sysfs_emit() is preferred for formatting sysfs output because it
provides safer bounds checking.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Link: https://patch.msgid.link/20260402164958.894879-4-thorsten.blum@linux.dev


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 4e56428e

block/partitions/core.c

+6 −5
Original line number Diff line number Diff line
@@ -8,6 +8,7 @@ 
#include <linux/major.h>

#include <linux/slab.h>

#include <linux/string.h>

#include <linux/sysfs.h>

#include <linux/ctype.h>

#include <linux/vmalloc.h>

#include <linux/raid/detect.h>
@@ -177,31 +178,31 @@ static struct parsed_partitions *check_partition(struct gendisk *hd) 
static ssize_t part_partition_show(struct device *dev,

				   struct device_attribute *attr, char *buf)

{

	return sprintf(buf, "%d\n", bdev_partno(dev_to_bdev(dev)));

	return sysfs_emit(buf, "%d\n", bdev_partno(dev_to_bdev(dev)));

}



static ssize_t part_start_show(struct device *dev,

			       struct device_attribute *attr, char *buf)

{

	return sprintf(buf, "%llu\n", dev_to_bdev(dev)->bd_start_sect);

	return sysfs_emit(buf, "%llu\n", dev_to_bdev(dev)->bd_start_sect);

}



static ssize_t part_ro_show(struct device *dev,

			    struct device_attribute *attr, char *buf)

{

	return sprintf(buf, "%d\n", bdev_read_only(dev_to_bdev(dev)));

	return sysfs_emit(buf, "%d\n", bdev_read_only(dev_to_bdev(dev)));

}



static ssize_t part_alignment_offset_show(struct device *dev,

					  struct device_attribute *attr, char *buf)

{

	return sprintf(buf, "%u\n", bdev_alignment_offset(dev_to_bdev(dev)));

	return sysfs_emit(buf, "%u\n", bdev_alignment_offset(dev_to_bdev(dev)));

}



static ssize_t part_discard_alignment_show(struct device *dev,

					   struct device_attribute *attr, char *buf)

{

	return sprintf(buf, "%u\n", bdev_discard_alignment(dev_to_bdev(dev)));

	return sysfs_emit(buf, "%u\n", bdev_discard_alignment(dev_to_bdev(dev)));

}



static DEVICE_ATTR(partition, 0444, part_partition_show, NULL);