Commit a1797599 authored by Adrian Moreno's avatar Adrian Moreno Committed by Jakub Kicinski
Browse files

selftests: openvswitch: fix tcpdump execution 



Fix the way tcpdump is executed by:
- Using the right variable for the namespace. Currently the use of the
  empty "ns" makes the command fail.
- Waiting until it starts to capture to ensure the interesting traffic
  is caught on slow systems.
- Using line-buffered output to ensure logs are available when the test
  is paused with "-p". Otherwise the last chunk of data might only be
  written when tcpdump is killed.

Fixes: 74cc26f4 ("selftests: openvswitch: add interface support")
Signed-off-by: default avatarAdrian Moreno <amorenoz@redhat.com>
Acked-by: default avatarEelco Chaudron <echaudro@redhat.com>
Link: https://patch.msgid.link/20241217211652.483016-1-amorenoz@redhat.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent dbfca164

tools/testing/selftests/net/openvswitch/openvswitch.sh

+4 −2
Original line number Diff line number Diff line
@@ -171,8 +171,10 @@ ovs_add_netns_and_veths () { 
		ovs_add_if "$1" "$2" "$4" -u || return 1

	fi



	[ $TRACING -eq 1 ] && ovs_netns_spawn_daemon "$1" "$ns" \

			tcpdump -i any -s 65535

	if [ $TRACING -eq 1 ]; then

		ovs_netns_spawn_daemon "$1" "$3" tcpdump -l -i any -s 6553

		ovs_wait grep -q "listening on any" ${ovs_dir}/stderr

	fi



	return 0

}