Commit a200df7d authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: seq: Don't clear bank selection at event -> UMP MIDI2 conversion 

The current code to convert from a legacy sequencer event to UMP MIDI2
clears the bank selection at each time the program change is
submitted.  This is confusing and may lead to incorrect bank values
tranmitted to the destination in the end.

Drop the line to clear the bank info and keep the provided values.

Fixes: e9e02819 ("ALSA: seq: Automatic conversion of UMP events")
Link: https://lore.kernel.org/r/20240527151852.29036-2-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 8a42886c

sound/core/seq/seq_ump_convert.c

+0 −1
Original line number Diff line number Diff line
@@ -892,7 +892,6 @@ static int pgm_ev_to_ump_midi2(const struct snd_seq_event *event, 
		data->pg.bank_msb = cc->cc_bank_msb;

		data->pg.bank_lsb = cc->cc_bank_lsb;

		cc->bank_set = 0;

		cc->cc_bank_msb = cc->cc_bank_lsb = 0;

	}

	return 1;

}