Commit a2558b41 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Jakub Kicinski
Browse files

net: bridge: constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Acked-by: default avatarNikolay Aleksandrov <razor@blackwall.org>
Link: https://patch.msgid.link/20241216-sysfs-const-bin_attr-net-v1-1-ec460b91f274@weissschuh.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent d3c9510d

net/bridge/br_sysfs_br.c

+3 −3
Original line number Diff line number Diff line
@@ -1002,7 +1002,7 @@ static const struct attribute_group bridge_group = { 
 * Returns the number of bytes read.

 */

static ssize_t brforward_read(struct file *filp, struct kobject *kobj,

			      struct bin_attribute *bin_attr,

			      const struct bin_attribute *bin_attr,

			      char *buf, loff_t off, size_t count)

{

	struct device *dev = kobj_to_dev(kobj);
@@ -1023,10 +1023,10 @@ static ssize_t brforward_read(struct file *filp, struct kobject *kobj, 
	return n;

}



static struct bin_attribute bridge_forward = {

static const struct bin_attribute bridge_forward = {

	.attr = { .name = SYSFS_BRIDGE_FDB,

		  .mode = 0444, },

	.read = brforward_read,

	.read_new = brforward_read,

};



/*