Commit a2633b6a authored by Nikolay Borisov's avatar Nikolay Borisov Committed by David Sterba
Browse files

btrfs: return bool from btrfs_should_end_transaction 



Results in slightly smaller code.

add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-11 (-11)
Function                                     old     new   delta
btrfs_should_end_transaction                  96      85     -11
Total: Before=20070, After=20059, chg -0.05%

Signed-off-by: default avatarNikolay Borisov <nborisov@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 8a8f4dea

fs/btrfs/transaction.c

+2 −2
Original line number Diff line number Diff line
@@ -908,14 +908,14 @@ static bool should_end_transaction(struct btrfs_trans_handle *trans) 
	return !!btrfs_block_rsv_check(&fs_info->global_block_rsv, 5);

}



int btrfs_should_end_transaction(struct btrfs_trans_handle *trans)

bool btrfs_should_end_transaction(struct btrfs_trans_handle *trans)

{

	struct btrfs_transaction *cur_trans = trans->transaction;



	smp_mb();

	if (cur_trans->state >= TRANS_STATE_COMMIT_START ||

	    cur_trans->delayed_refs.flushing)

		return 1;

		return true;



	return should_end_transaction(trans);

}

fs/btrfs/transaction.h

+1 −1
Original line number Diff line number Diff line
@@ -218,7 +218,7 @@ int btrfs_commit_transaction(struct btrfs_trans_handle *trans); 
int btrfs_commit_transaction_async(struct btrfs_trans_handle *trans,

				   int wait_for_unblock);

int btrfs_end_transaction_throttle(struct btrfs_trans_handle *trans);

int btrfs_should_end_transaction(struct btrfs_trans_handle *trans);

bool btrfs_should_end_transaction(struct btrfs_trans_handle *trans);

void btrfs_throttle(struct btrfs_fs_info *fs_info);

int btrfs_record_root_in_trans(struct btrfs_trans_handle *trans,

				struct btrfs_root *root);