Commit a2646773 authored by Ido Schimmel's avatar Ido Schimmel Committed by Jakub Kicinski
Browse files

selftests: mlxsw: tc_restrictions: Fix test failure with new iproute2 

As explained in [1], iproute2 started rejecting tc-police burst sizes
that result in an overflow. This can happen when the burst size is high
enough and the rate is low enough.

A couple of test cases specify such configurations, resulting in
iproute2 errors and test failure.

Fix by reducing the burst size so that the test will pass with both new
and old iproute2 versions.

[1] https://lore.kernel.org/netdev/20250916215731.3431465-1-jay.vosburgh@canonical.com/



Fixes: cb12d176 ("selftests: mlxsw: tc_restrictions: Test tc-police restrictions")
Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/88b00c6e85188aa6a065dc240206119b328c46e1.1770643998.git.petrm@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a6a9bc54

tools/testing/selftests/drivers/net/mlxsw/tc_restrictions.sh

+2 −2
Original line number Diff line number Diff line
@@ -317,7 +317,7 @@ police_limits_test() 


	tc filter add dev $swp1 ingress pref 1 proto ip handle 101 \

		flower skip_sw \

		action police rate 0.5kbit burst 1m conform-exceed drop/ok

		action police rate 0.5kbit burst 2k conform-exceed drop/ok

	check_fail $? "Incorrect success to add police action with too low rate"



	tc filter add dev $swp1 ingress pref 1 proto ip handle 101 \
@@ -327,7 +327,7 @@ police_limits_test() 


	tc filter add dev $swp1 ingress pref 1 proto ip handle 101 \

		flower skip_sw \

		action police rate 1.5kbit burst 1m conform-exceed drop/ok

		action police rate 1.5kbit burst 2k conform-exceed drop/ok

	check_err $? "Failed to add police action with low rate"



	tc filter del dev $swp1 ingress protocol ip pref 1 handle 101 flower