Commit a297c516 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Hans Verkuil
Browse files

media: iris: fix QCOM_MDT_LOADER dependency 



When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_IRIS=y,
the kernel fails to link:

x86_64-linux-ld: drivers/media/platform/qcom/iris/iris_firmware.o: in function `iris_fw_load':
iris_firmware.c:(.text+0xb0): undefined reference to `qcom_mdt_get_size'
iris_firmware.c:(.text+0xfd): undefined reference to `qcom_mdt_load'

The problem is the conditional 'select' statement. Change this to
make the driver built-in here regardless of CONFIG_ARCH_QCOM.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: default avatarDikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Reviewed-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Fixes: d19b1633 ("media: iris: implement video firmware load/unload")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarBryan O'Donoghue <bod@kernel.org>
Signed-off-by: default avatarHans Verkuil <hverkuil+cisco@kernel.org>
parent aa23c94c

drivers/media/platform/qcom/iris/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -3,7 +3,7 @@ config VIDEO_QCOM_IRIS 
        depends on VIDEO_DEV

        depends on ARCH_QCOM || COMPILE_TEST

        select V4L2_MEM2MEM_DEV

        select QCOM_MDT_LOADER if ARCH_QCOM

        select QCOM_MDT_LOADER

        select QCOM_SCM

        select VIDEOBUF2_DMA_CONTIG

        help