Commit a2b579c4 authored by James Clark's avatar James Clark Committed by Marc Zyngier
Browse files

coresight: trbe: Remove redundant disable call 



trbe_drain_and_disable_local() just clears TRBLIMITR and drains.
TRBLIMITR is already cleared on the next line after this call, so
replace it with only drain. This is so we can make a kvm call that has a
preempt enabled warning from set_trbe_disabled() in the next commit,
where trbe_reset_local() is called from a preemptible hotplug path.

Signed-off-by: default avatarJames Clark <james.clark@linaro.org>
Link: https://lore.kernel.org/r/20250106142446.628923-5-james.clark@linaro.org


Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
parent c382ee67

drivers/hwtracing/coresight/coresight-trbe.c

+1 −1
Original line number Diff line number Diff line
@@ -253,8 +253,8 @@ static void trbe_drain_and_disable_local(struct trbe_cpudata *cpudata) 


static void trbe_reset_local(struct trbe_cpudata *cpudata)

{

	trbe_drain_and_disable_local(cpudata);

	write_sysreg_s(0, SYS_TRBLIMITR_EL1);

	trbe_drain_buffer();

	write_sysreg_s(0, SYS_TRBPTR_EL1);

	write_sysreg_s(0, SYS_TRBBASER_EL1);

	write_sysreg_s(0, SYS_TRBSR_EL1);