Commit a2da597f authored by Dan Carpenter's avatar Dan Carpenter Committed by Thierry Reding
Browse files

pwm: samsung: Fix a bit test in pwm_samsung_resume() 



The PWMF_REQUESTED enum is supposed to be used with test_bit() and not
used as in a bitwise AND.  In this specific code the flag will never be
set so the function is effectively a no-op.

Fixes: e3fe982b ("pwm: samsung: Put per-channel data into driver data")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarSam Protsenko <semen.protsenko@linaro.org>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 40592064

drivers/pwm/pwm-samsung.c

+1 −1
Original line number Diff line number Diff line
@@ -631,7 +631,7 @@ static int pwm_samsung_resume(struct device *dev) 
		struct pwm_device *pwm = &chip->pwms[i];

		struct samsung_pwm_channel *chan = &our_chip->channel[i];



		if (!(pwm->flags & PWMF_REQUESTED))

		if (!test_bit(PWMF_REQUESTED, &pwm->flags))

			continue;



		if (our_chip->variant.output_mask & BIT(i))