Commit a318eb80 authored by Alok Tiwari's avatar Alok Tiwari Committed by Michael S. Tsirkin
Browse files

vhost-scsi: fix argument order in tport allocation error message 



The error log in vhost_scsi_make_tport() prints the arguments in the
wrong order, producing confusing output. For example, when creating a
target with a name in WWNN format such as "fc.port1234", the log
looks like:

  Emulated fc.port1234 Address: FCP, exceeds max: 64

Instead, the message should report the emulated protocol type first,
followed by the configfs name as:

  Emulated FCP Address: fc.port1234, exceeds max: 64

Fix the argument order so the error log is consistent and clear.

Signed-off-by: default avatarAlok Tiwari <alok.a.tiwari@oracle.com>
Message-Id: <20250913154106.3995856-1-alok.a.tiwari@oracle.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent 76eeb9b8

drivers/vhost/scsi.c

+1 −1
Original line number Diff line number Diff line
@@ -2884,7 +2884,7 @@ vhost_scsi_make_tport(struct target_fabric_configfs *tf, 
check_len:

	if (strlen(name) >= VHOST_SCSI_NAMELEN) {

		pr_err("Emulated %s Address: %s, exceeds"

			" max: %d\n", name, vhost_scsi_dump_proto_id(tport),

			" max: %d\n", vhost_scsi_dump_proto_id(tport), name,

			VHOST_SCSI_NAMELEN);

		kfree(tport);

		return ERR_PTR(-EINVAL);