Commit a3218464 authored by Peter Hurley's avatar Peter Hurley Committed by Greg Kroah-Hartman
Browse files

staging/fwserial: Destruct embedded tty_port on teardown 



For TTY drivers that manage the port lifetime, the tty_port should
to be specifically destructed when the port lifetime ends. Now that
a method has been added to do this, use it.

Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
parent eef6e7b2

drivers/staging/fwserial/fwserial.c

+4 −1
Original line number Diff line number Diff line
@@ -955,6 +955,7 @@ static void fwserial_destroy(struct kref *kref) 
	for (j = 0; j < num_ports; ++j) {

		fw_core_remove_address_handler(&ports[j]->rx_handler);

		dma_fifo_free(&ports[j]->tx_fifo);

		tty_port_destroy(&ports[j]->port);

		kfree(ports[j]);

	}

	kfree(serial);
@@ -2369,8 +2370,10 @@ static int fwserial_create(struct fw_unit *unit) 
	return err;



free_ports:

	for (--i; i >= 0; --i)

	for (--i; i >= 0; --i) {

		tty_port_destroy(&serial->ports[i]->port);

		kfree(serial->ports[i]);

	}

	kfree(serial);

	return err;

}