Commit a33958ca authored by Yangyang Li's avatar Yangyang Li Committed by Jason Gunthorpe
Browse files

RDMA/hns: Modify function return value type 

hns_roce_init_qp_table() will only return 0, because this function does
not need to return a value, so it is modified to void type.

Link: https://lore.kernel.org/r/1624011020-16992-8-git-send-email-liweihang@huawei.com


Signed-off-by: default avatarYangyang Li <liyangyang20@huawei.com>
Signed-off-by: default avatarWeihang Li <liweihang@huawei.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent c2614b99

drivers/infiniband/hw/hns/hns_roce_device.h

+1 −1
Original line number Diff line number Diff line
@@ -1146,7 +1146,7 @@ int hns_roce_mtr_map(struct hns_roce_dev *hr_dev, struct hns_roce_mtr *mtr, 
void hns_roce_init_pd_table(struct hns_roce_dev *hr_dev);

void hns_roce_init_mr_table(struct hns_roce_dev *hr_dev);

void hns_roce_init_cq_table(struct hns_roce_dev *hr_dev);

int hns_roce_init_qp_table(struct hns_roce_dev *hr_dev);

void hns_roce_init_qp_table(struct hns_roce_dev *hr_dev);

int hns_roce_init_srq_table(struct hns_roce_dev *hr_dev);

void hns_roce_init_xrcd_table(struct hns_roce_dev *hr_dev);

drivers/infiniband/hw/hns/hns_roce_main.c

+1 −7
Original line number Diff line number Diff line
@@ -757,11 +757,7 @@ static int hns_roce_setup_hca(struct hns_roce_dev *hr_dev) 


	hns_roce_init_cq_table(hr_dev);



	ret = hns_roce_init_qp_table(hr_dev);

	if (ret) {

		dev_err(dev, "Failed to init queue pair table.\n");

		goto err_cq_table_free;

	}

	hns_roce_init_qp_table(hr_dev);



	if (hr_dev->caps.flags & HNS_ROCE_CAP_FLAG_SRQ) {

		ret = hns_roce_init_srq_table(hr_dev);
@@ -776,8 +772,6 @@ static int hns_roce_setup_hca(struct hns_roce_dev *hr_dev) 


err_qp_table_free:

	hns_roce_cleanup_qp_table(hr_dev);



err_cq_table_free:

	hns_roce_cleanup_cq_table(hr_dev);

	ida_destroy(&hr_dev->mr_table.mtpt_ida.ida);

drivers/infiniband/hw/hns/hns_roce_qp.c

+1 −3
Original line number Diff line number Diff line
@@ -1414,7 +1414,7 @@ bool hns_roce_wq_overflow(struct hns_roce_wq *hr_wq, u32 nreq, 
	return cur + nreq >= hr_wq->wqe_cnt;

}



int hns_roce_init_qp_table(struct hns_roce_dev *hr_dev)

void hns_roce_init_qp_table(struct hns_roce_dev *hr_dev)

{

	struct hns_roce_qp_table *qp_table = &hr_dev->qp_table;

	unsigned int reserved_from_bot;
@@ -1437,8 +1437,6 @@ int hns_roce_init_qp_table(struct hns_roce_dev *hr_dev) 
					       HNS_ROCE_QP_BANK_NUM - 1;

		hr_dev->qp_table.bank[i].next = hr_dev->qp_table.bank[i].min;

	}



	return 0;

}



void hns_roce_cleanup_qp_table(struct hns_roce_dev *hr_dev)