Commit a3951680 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

tools build: Don't assume libtracefs-devel is always available 



perf doesn't use libtracefs and so it doesn't make sense to assume it is
always available when building test-all.bin, defeating the feature check
speedup it provides.

The other tools/build/ users such as rtla, rv, etc call $(feature_check
libtracefs) to check its availability instead of using the test-all.bin
mechanism, stopping the build and asking for libtracefs-devel to be
installed.

Remove it from FEATURE_TESTS_BASIC to not have it as available, as noted
by Ian Rogers during review.

Reviewed-by: default avatarIan Rogers <irogers@google.com>
Acked-by: default avatarTomas Glozar <tglozar@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Gabriele Monaco <gmonaco@redhat.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent b19a0f61

tools/build/Makefile.feature

+0 −1
Original line number Diff line number Diff line
@@ -83,7 +83,6 @@ FEATURE_TESTS_BASIC := \ 
        libpython                       \

        libslang                        \

        libtraceevent                   \

        libtracefs                      \

        libcpupower                     \

        pthread-attr-setaffinity-np     \

        pthread-barrier     		\

tools/build/feature/test-all.c

+0 −5
Original line number Diff line number Diff line
@@ -150,10 +150,6 @@ 
# include "test-libtraceevent.c"

#undef main



#define main main_test_libtracefs

# include "test-libtracefs.c"

#undef main



int main(int argc, char *argv[])

{

	main_test_libpython();
@@ -187,7 +183,6 @@ int main(int argc, char *argv[]) 
	main_test_reallocarray();

	main_test_libzstd();

	main_test_libtraceevent();

	main_test_libtracefs();



	return 0;

}