Commit a3a22373 authored by Dmitry Baryshkov's avatar Dmitry Baryshkov Committed by Rob Clark
Browse files

drm/msm/a2xx: stop over-complaining about the legacy firmware 



If the rootfs have a legacy A200 firmware, currently the driver will
complain each time the hw is reinited (which can happen a lot). E.g.
with GL testsuite the hw is reinited after each test, spamming the
console.

Make sure that the message is printed only once: when we detect the
firmware that doesn't support protection.

Fixes: 30229507 ("drm/msm/a2xx: support loading legacy (iMX) firmware")
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/688098/


Signed-off-by: default avatarRob Clark <robin.clark@oss.qualcomm.com>
parent 3065e6a4

drivers/gpu/drm/msm/adreno/a2xx_gpu.c

+1 −1
Original line number Diff line number Diff line
@@ -234,7 +234,7 @@ static int a2xx_hw_init(struct msm_gpu *gpu) 
	 * word (0x20xxxx for A200, 0x220xxx for A220, 0x225xxx for A225).

	 * Older firmware files, which lack protection support, have 0 instead.

	 */

	if (ptr[1] == 0) {

	if (ptr[1] == 0 && !a2xx_gpu->protection_disabled) {

		dev_warn(gpu->dev->dev,

			 "Legacy firmware detected, disabling protection support\n");

		a2xx_gpu->protection_disabled = true;