Commit a3a96873 authored by Robert Richter's avatar Robert Richter Committed by Dave Jiang
Browse files

cxl/region: Rename function to cxl_port_pick_region_decoder() 



Current function cxl_region_find_decoder() is used to find a port's
decoder during region setup. In the region creation path the function
is an allocator to find a free port. In the region assembly path, it
is recalling the decoder that platform firmware picked for validation
purposes.

Rename function to cxl_port_pick_region_decoder() that better
describes its use and update the function's description.

The result of cxl_port_pick_region_decoder() is recorded in a 'struct
cxl_region_ref' in @port for later recall when other endpoints might
also be targets of the picked decoder.

Signed-off-by: default avatarRobert Richter <rrichter@amd.com>
Reviewed-by: default avatarGregory Price <gourry@gourry.net>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Reviewed-by: default avatar"Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>
Tested-by: default avatarGregory Price <gourry@gourry.net>
Acked-by: default avatarDan Williams <dan.j.williams@intel.com>
Link: https://patch.msgid.link/20250509150700.2817697-6-rrichter@amd.com


Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
parent 99ff9060

drivers/cxl/core/region.c

+18 −5
Original line number Diff line number Diff line
@@ -864,8 +864,21 @@ static int match_auto_decoder(struct device *dev, const void *data) 
	return 0;

}



/**

 * cxl_port_pick_region_decoder() - assign or lookup a decoder for a region

 * @port: a port in the ancestry of the endpoint implied by @cxled

 * @cxled: endpoint decoder to be, or currently, mapped by @port

 * @cxlr: region to establish, or validate, decode @port

 *

 * In the region creation path cxl_port_pick_region_decoder() is an

 * allocator to find a free port. In the region assembly path, it is

 * recalling the decoder that platform firmware picked for validation

 * purposes.

 *

 * The result is recorded in a 'struct cxl_region_ref' in @port.

 */

static struct cxl_decoder *

cxl_region_find_decoder(struct cxl_port *port,

cxl_port_pick_region_decoder(struct cxl_port *port,

			     struct cxl_endpoint_decoder *cxled,

			     struct cxl_region *cxlr)

{
@@ -931,7 +944,7 @@ alloc_region_ref(struct cxl_port *port, struct cxl_region *cxlr, 
		if (test_bit(CXL_REGION_F_AUTO, &cxlr->flags)) {

			struct cxl_decoder *cxld;



			cxld = cxl_region_find_decoder(port, cxled, cxlr);

			cxld = cxl_port_pick_region_decoder(port, cxled, cxlr);

			if (auto_order_ok(port, iter->region, cxld))

				continue;

		}
@@ -1019,7 +1032,7 @@ static int cxl_rr_alloc_decoder(struct cxl_port *port, struct cxl_region *cxlr, 
{

	struct cxl_decoder *cxld;



	cxld = cxl_region_find_decoder(port, cxled, cxlr);

	cxld = cxl_port_pick_region_decoder(port, cxled, cxlr);

	if (!cxld) {

		dev_dbg(&cxlr->dev, "%s: no decoder available\n",

			dev_name(&port->dev));