Unverified Commit a3c86b6d authored by Bommu Krishnaiah's avatar Bommu Krishnaiah Committed by Rodrigo Vivi
Browse files

drm/xe: prefer snprintf over sprintf 



since the sprintf() function lacks built-in protection against buffer
overflows using the snprintf() function.

v2: Removed hard coded values and used sizeof()

Signed-off-by: default avatarBommu Krishnaiah <krishnaiah.bommu@intel.com>
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
Reviewed-by: default avatarHimal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231209235949.54524-2-krishnaiah.bommu@intel.com


Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 972d01d0

drivers/gpu/drm/xe/xe_debugfs.c

+1 −1
Original line number Diff line number Diff line
@@ -129,7 +129,7 @@ void xe_debugfs_register(struct xe_device *xe) 
		if (man) {

			char name[16];



			sprintf(name, "vram%d_mm", mem_type - XE_PL_VRAM0);

			snprintf(name, sizeof(name), "vram%d_mm", mem_type - XE_PL_VRAM0);

			ttm_resource_manager_create_debugfs(man, root, name);

		}

	}

drivers/gpu/drm/xe/xe_exec_queue.c

+6 −6
Original line number Diff line number Diff line
@@ -225,22 +225,22 @@ void xe_exec_queue_assign_name(struct xe_exec_queue *q, u32 instance) 
{

	switch (q->class) {

	case XE_ENGINE_CLASS_RENDER:

		sprintf(q->name, "rcs%d", instance);

		snprintf(q->name, sizeof(q->name), "rcs%d", instance);

		break;

	case XE_ENGINE_CLASS_VIDEO_DECODE:

		sprintf(q->name, "vcs%d", instance);

		snprintf(q->name, sizeof(q->name), "vcs%d", instance);

		break;

	case XE_ENGINE_CLASS_VIDEO_ENHANCE:

		sprintf(q->name, "vecs%d", instance);

		snprintf(q->name, sizeof(q->name), "vecs%d", instance);

		break;

	case XE_ENGINE_CLASS_COPY:

		sprintf(q->name, "bcs%d", instance);

		snprintf(q->name, sizeof(q->name), "bcs%d", instance);

		break;

	case XE_ENGINE_CLASS_COMPUTE:

		sprintf(q->name, "ccs%d", instance);

		snprintf(q->name, sizeof(q->name), "ccs%d", instance);

		break;

	case XE_ENGINE_CLASS_OTHER:

		sprintf(q->name, "gsccs%d", instance);

		snprintf(q->name, sizeof(q->name), "gsccs%d", instance);

		break;

	default:

		XE_WARN_ON(q->class);

drivers/gpu/drm/xe/xe_gt_debugfs.c

+1 −1
Original line number Diff line number Diff line
@@ -269,7 +269,7 @@ void xe_gt_debugfs_register(struct xe_gt *gt) 


	xe_gt_assert(gt, minor->debugfs_root);



	sprintf(name, "gt%d", gt->info.id);

	snprintf(name, sizeof(name), "gt%d", gt->info.id);

	root = debugfs_create_dir(name, minor->debugfs_root);

	if (IS_ERR(root)) {

		drm_warn(&xe->drm, "Create GT directory failed");

drivers/gpu/drm/xe/xe_gt_idle.c

+2 −2
Original line number Diff line number Diff line
@@ -166,10 +166,10 @@ void xe_gt_idle_sysfs_init(struct xe_gt_idle *gtidle) 
	}



	if (xe_gt_is_media_type(gt)) {

		sprintf(gtidle->name, "gt%d-mc", gt->info.id);

		snprintf(gtidle->name, sizeof(gtidle->name), "gt%d-mc", gt->info.id);

		gtidle->idle_residency = xe_guc_pc_mc6_residency;

	} else {

		sprintf(gtidle->name, "gt%d-rc", gt->info.id);

		snprintf(gtidle->name, sizeof(gtidle->name), "gt%d-rc", gt->info.id);

		gtidle->idle_residency = xe_guc_pc_rc6_residency;

	}

drivers/gpu/drm/xe/xe_hw_fence.c

+1 −1
Original line number Diff line number Diff line
@@ -130,7 +130,7 @@ void xe_hw_fence_ctx_init(struct xe_hw_fence_ctx *ctx, struct xe_gt *gt, 
	ctx->irq = irq;

	ctx->dma_fence_ctx = dma_fence_context_alloc(1);

	ctx->next_seqno = XE_FENCE_INITIAL_SEQNO;

	sprintf(ctx->name, "%s", name);

	snprintf(ctx->name, sizeof(ctx->name), "%s", name);

}



void xe_hw_fence_ctx_finish(struct xe_hw_fence_ctx *ctx)