Commit a3f143c4 authored by Manas's avatar Manas Committed by Jens Axboe
Browse files

rust: block: simplify Result<()> in validate_block_size return 



`Result` is used in place of `Result<()>` because the default type
parameters are unit `()` and `Error` types, which are automatically
inferred. Thus keep the usage consistent throughout codebase.

Suggested-by: default avatarMiguel Ojeda <ojeda@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1128


Signed-off-by: default avatarManas <manas18244@iiitd.ac.in>
Reviewed-by: default avatarMiguel Ojeda <ojeda@kernel.org>
Link: https://lore.kernel.org/r/20241118-simplify-result-v3-1-6b1566a77eab@iiitd.ac.in


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 88d47f62

rust/kernel/block/mq/gen_disk.rs

+1 −1
Original line number Diff line number Diff line
@@ -45,7 +45,7 @@ pub fn rotational(mut self, rotational: bool) -> Self { 


    /// Validate block size by verifying that it is between 512 and `PAGE_SIZE`,

    /// and that it is a power of two.

    fn validate_block_size(size: u32) -> Result<()> {

    fn validate_block_size(size: u32) -> Result {

        if !(512..=bindings::PAGE_SIZE as u32).contains(&size) || !size.is_power_of_two() {

            Err(error::code::EINVAL)

        } else {