Commit a409e919 authored by Shuai Xue's avatar Shuai Xue Committed by Vinod Koul
Browse files

dmaengine: idxd: Refactor remove call with idxd_cleanup() helper 



The idxd_cleanup() helper cleans up perfmon, interrupts, internals and
so on. Refactor remove call with the idxd_cleanup() helper to avoid code
duplication. Note, this also fixes the missing put_device() for idxd
groups, enginces and wqs.

Fixes: bfe1d560 ("dmaengine: idxd: Init and probe for Intel data accelerators")
Cc: stable@vger.kernel.org
Suggested-by: default avatarVinicius Costa Gomes <vinicius.gomes@intel.com>
Signed-off-by: default avatarShuai Xue <xueshuai@linux.alibaba.com>
Reviewed-by: default avatarFenghua Yu <fenghuay@nvidia.com>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/20250404120217.48772-10-xueshuai@linux.alibaba.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent d5449ff1

drivers/dma/idxd/init.c

+2 −12
Original line number Diff line number Diff line
@@ -1308,7 +1308,6 @@ static void idxd_shutdown(struct pci_dev *pdev) 
static void idxd_remove(struct pci_dev *pdev)

{

	struct idxd_device *idxd = pci_get_drvdata(pdev);

	struct idxd_irq_entry *irq_entry;



	idxd_unregister_devices(idxd);

	/*
@@ -1321,21 +1320,12 @@ static void idxd_remove(struct pci_dev *pdev) 
	get_device(idxd_confdev(idxd));

	device_unregister(idxd_confdev(idxd));

	idxd_shutdown(pdev);

	if (device_pasid_enabled(idxd))

		idxd_disable_system_pasid(idxd);

	idxd_device_remove_debugfs(idxd);



	irq_entry = idxd_get_ie(idxd, 0);

	free_irq(irq_entry->vector, irq_entry);

	pci_free_irq_vectors(pdev);

	idxd_cleanup(idxd);

	pci_iounmap(pdev, idxd->reg_base);

	if (device_user_pasid_enabled(idxd))

		idxd_disable_sva(pdev);

	pci_disable_device(pdev);

	destroy_workqueue(idxd->wq);

	perfmon_pmu_remove(idxd);

	put_device(idxd_confdev(idxd));

	idxd_free(idxd);

	pci_disable_device(pdev);

}



static struct pci_driver idxd_pci_driver = {