Commit a424a34b authored Feb 09, 2026 by Raul E Rangel Committed by Greg Kroah-Hartman Mar 12, 2026

serial: 8250: Fix TX deadlock when using DMA



`dmaengine_terminate_async` does not guarantee that the
`__dma_tx_complete` callback will run. The callback is currently the
only place where `dma->tx_running` gets cleared. If the transaction is
canceled and the callback never runs, then `dma->tx_running` will never
get cleared and we will never schedule new TX DMA transactions again.

This change makes it so we clear `dma->tx_running` after we terminate
the DMA transaction. This is "safe" because `serial8250_tx_dma_flush`
is holding the UART port lock. The first thing the callback does is also
grab the UART port lock, so access to `dma->tx_running` is serialized.

Fixes: 9e512eaa ("serial: 8250: Fix fifo underflow on flush")
Cc: stable <stable@kernel.org>
Signed-off-by: Raul E Rangel <rrangel@google.com>
Link: https://patch.msgid.link/20260209135815.1.I16366ecb0f62f3c96fe3dd5763fcf6f3c2b4d8cd@changeid


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 1f318b96

drivers/tty/serial/8250/8250_dma.c

+15 −0

Original line number	Diff line number	Diff line
		@@ -162,7 +162,22 @@ void serial8250_tx_dma_flush(struct uart_8250_port *p)
		*/
		dma->tx_size = 0;

		/*
		* We can't use `dmaengine_terminate_sync` because `uart_flush_buffer` is
		* holding the uart port spinlock.
		*/
		dmaengine_terminate_async(dma->txchan);

		/*
		* The callback might or might not run. If it doesn't run, we need to ensure
		* that `tx_running` is cleared so that we can schedule new transactions.
		* If it does run, then the zombie callback will clear `tx_running` again
		* and perform a no-op since `tx_size` was cleared above.
		*
		* In either case, we ASSUME the DMA transaction will terminate before we
		* issue a new `serial8250_tx_dma`.
		*/
		dma->tx_running = 0;
		}

		int serial8250_rx_dma(struct uart_8250_port *p)