Commit a42f3076 authored by Matthieu Baerts (NGI0)'s avatar Matthieu Baerts (NGI0) Committed by Jakub Kicinski
Browse files

mptcp: pm: send ACK on non-stale subflows 



If the subflow is considered as "staled", it is better to avoid it to
send an ACK carrying an ADD_ADDR or RM_ADDR. Another subflow, if any,
will then be selected.

Reviewed-by: default avatarMat Martineau <martineau@kernel.org>
Signed-off-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20241021-net-next-mptcp-misc-6-13-v1-1-1ef02746504a@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent fbb26ecc

net/mptcp/pm_netlink.c

+11 −3
Original line number Diff line number Diff line
@@ -781,7 +781,7 @@ bool mptcp_pm_nl_is_init_remote_addr(struct mptcp_sock *msk, 


void mptcp_pm_nl_addr_send_ack(struct mptcp_sock *msk)

{

	struct mptcp_subflow_context *subflow;

	struct mptcp_subflow_context *subflow, *alt = NULL;



	msk_owned_by_me(msk);

	lockdep_assert_held(&msk->pm.lock);
@@ -792,10 +792,18 @@ void mptcp_pm_nl_addr_send_ack(struct mptcp_sock *msk) 


	mptcp_for_each_subflow(msk, subflow) {

		if (__mptcp_subflow_active(subflow)) {

			if (!subflow->stale) {

				mptcp_pm_send_ack(msk, subflow, false, false);

			break;

				return;

			}



			if (!alt)

				alt = subflow;

		}

	}



	if (alt)

		mptcp_pm_send_ack(msk, alt, false, false);

}



int mptcp_pm_nl_mp_prio_send_ack(struct mptcp_sock *msk,