Commit a4399657 authored by Luben Tuikov's avatar Luben Tuikov Committed by Alex Deucher
Browse files

drm/amdgpu: Rename misspelled function 



Instead of fixing the spelling in
  amdgpu_ras_eeprom_process_recods(),
rename it to,
  amdgpu_ras_eeprom_xfer(),
to look similar to other I2C and protocol
transfer (read/write) functions.

Also to keep the column span to within reason by
using a shorter name.

Change the "num" function parameter from "int" to
"const u32" since it is the number of items
(records) to xfer, i.e. their count, which cannot
be a negative number.

Also swap the order of parameters, keeping the
pointer to records and their number next to each
other, while the direction now becomes the last
parameter.

Cc: Jean Delvare <jdelvare@suse.de>
Cc: Alexander Deucher <Alexander.Deucher@amd.com>
Cc: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
Cc: Lijo Lazar <Lijo.Lazar@amd.com>
Cc: Stanley Yang <Stanley.Yang@amd.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: default avatarLuben Tuikov <luben.tuikov@amd.com>
Acked-by: default avatarAlexander Deucher <Alexander.Deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c28aa44d

drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

+5 −6
Original line number Diff line number Diff line
@@ -1817,10 +1817,10 @@ int amdgpu_ras_save_bad_pages(struct amdgpu_device *adev) 
	save_count = data->count - control->num_recs;

	/* only new entries are saved */

	if (save_count > 0) {

		if (amdgpu_ras_eeprom_process_recods(control,

		if (amdgpu_ras_eeprom_xfer(control,

					   &data->bps[control->num_recs],

							true,

							save_count)) {

					   save_count,

					   true)) {

			dev_err(adev->dev, "Failed to save EEPROM table data!");

			return -EIO;

		}
@@ -1850,8 +1850,7 @@ static int amdgpu_ras_load_bad_pages(struct amdgpu_device *adev) 
	if (!bps)

		return -ENOMEM;



	if (amdgpu_ras_eeprom_process_recods(control, bps, false,

		control->num_recs)) {

	if (amdgpu_ras_eeprom_xfer(control, bps, control->num_recs, false)) {

		dev_err(adev->dev, "Failed to load EEPROM table records!");

		ret = -EIO;

		goto out;

drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c

+5 −5
Original line number Diff line number Diff line
@@ -432,9 +432,9 @@ bool amdgpu_ras_eeprom_check_err_threshold(struct amdgpu_device *adev) 
	return false;

}



int amdgpu_ras_eeprom_process_recods(struct amdgpu_ras_eeprom_control *control,

int amdgpu_ras_eeprom_xfer(struct amdgpu_ras_eeprom_control *control,

			   struct eeprom_table_record *records,

				     bool write, int num)

			   const u32 num, bool write)

{

	int i, ret = 0;

	unsigned char *buffs, *buff;
@@ -574,13 +574,13 @@ void amdgpu_ras_eeprom_test(struct amdgpu_ras_eeprom_control *control) 
		recs[i].retired_page = i;

	}



	if (!amdgpu_ras_eeprom_process_recods(control, recs, true, 1)) {

	if (!amdgpu_ras_eeprom_xfer(control, recs, 1, true)) {



		memset(recs, 0, sizeof(*recs) * 1);



		control->next_addr = RAS_RECORD_START;



		if (!amdgpu_ras_eeprom_process_recods(control, recs, false, 1)) {

		if (!amdgpu_ras_eeprom_xfer(control, recs, 1, false)) {

			for (i = 0; i < 1; i++)

				DRM_INFO("rec.address :0x%llx, rec.retired_page :%llu",

					 recs[i].address, recs[i].retired_page);

drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.h

+3 −4
Original line number Diff line number Diff line
@@ -82,10 +82,9 @@ int amdgpu_ras_eeprom_reset_table(struct amdgpu_ras_eeprom_control *control); 


bool amdgpu_ras_eeprom_check_err_threshold(struct amdgpu_device *adev);



int amdgpu_ras_eeprom_process_recods(struct amdgpu_ras_eeprom_control *control,

int amdgpu_ras_eeprom_xfer(struct amdgpu_ras_eeprom_control *control,

			   struct eeprom_table_record *records,

					    bool write,

					    int num);

			   const u32 num, bool write);



inline uint32_t amdgpu_ras_eeprom_get_record_max_length(void);