Commit a47f3320 authored by Johan Hovold's avatar Johan Hovold Committed by Johannes Berg
Browse files

wifi: ath12k: fix soft lockup on suspend 



The ext interrupts are enabled when the firmware has been started, but
this may never happen, for example, if the board configuration file is
missing.

When the system is later suspended, the driver unconditionally tries to
disable interrupts, which results in an irq disable imbalance and causes
the driver to spin indefinitely in napi_synchronize().

Make sure that the interrupts have been enabled before attempting to
disable them.

Fixes: d8899132 ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Cc: stable@vger.kernel.org	# 6.3
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Acked-by: default avatarJeff Johnson <quic_jjohnson@quicinc.com>
Link: https://patch.msgid.link/20240709073132.9168-1-johan+linaro@kernel.org


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 6557a28f

drivers/net/wireless/ath/ath12k/pci.c

+2 −1
Original line number Diff line number Diff line
@@ -473,7 +473,8 @@ static void __ath12k_pci_ext_irq_disable(struct ath12k_base *ab) 
{

	int i;



	clear_bit(ATH12K_FLAG_EXT_IRQ_ENABLED, &ab->dev_flags);

	if (!test_and_clear_bit(ATH12K_FLAG_EXT_IRQ_ENABLED, &ab->dev_flags))

		return;



	for (i = 0; i < ATH12K_EXT_IRQ_GRP_NUM_MAX; i++) {

		struct ath12k_ext_irq_grp *irq_grp = &ab->ext_irq_grp[i];