Commit a4b79af6 authored by Ye Liu's avatar Ye Liu Committed by Andrew Morton
Browse files

mm/numa: remove unnecessary local variable in alloc_node_data() 

The temporary local variable 'nd' is redundant.  Directly assign the
virtual address to node_data[nid] to simplify the code.

No functional change.

Link: https://lkml.kernel.org/r/20250427100442.958352-4-ye.liu@linux.dev


Signed-off-by: default avatarYe Liu <liuye@kylinos.cn>
Acked-by: default avatarDavid Hildenbrand <david@redhat.com>
Reviewed-by: default avatarMike Rapoport (Microsoft) <rppt@kernel.org>
Reviewed-by: default avatarAnshuman Khandual <anshuman.khandual@arm.com>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Rik van Riel <riel@surriel.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 4048774e

mm/numa.c

+1 −3
Original line number Diff line number Diff line
@@ -13,7 +13,6 @@ void __init alloc_node_data(int nid) 
{

	const size_t nd_size = roundup(sizeof(pg_data_t), SMP_CACHE_BYTES);

	u64 nd_pa;

	void *nd;

	int tnid;



	/* Allocate node data.  Try node-local memory and then any node. */
@@ -21,7 +20,6 @@ void __init alloc_node_data(int nid) 
	if (!nd_pa)

		panic("Cannot allocate %zu bytes for node %d data\n",

		      nd_size, nid);

	nd = __va(nd_pa);



	/* report and initialize */

	pr_info("NODE_DATA(%d) allocated [mem %#010Lx-%#010Lx]\n", nid,
@@ -30,7 +28,7 @@ void __init alloc_node_data(int nid) 
	if (tnid != nid)

		pr_info("    NODE_DATA(%d) on node %d\n", nid, tnid);



	node_data[nid] = nd;

	node_data[nid] = __va(nd_pa);

	memset(NODE_DATA(nid), 0, sizeof(pg_data_t));

}