Commit a508d5af authored by Marc Zyngier's avatar Marc Zyngier Committed by Oliver Upton
Browse files

KVM: arm64: Remove the wi->{e0,}poe vs wr->{p,u}ov confusion 



Some of the POE computation is a bit confused. Specifically, there
is an element of confusion between what wi->{e0,}poe an wr->{p,u}ov
actually represent.

- wi->{e0,}poe is an *input* to the walk, and indicates whether
  POE is enabled at EL0 or EL{1,2}

- wr->{p,u}ov is a *result* of the walk, and indicates whether
  overlays are enabled. Crutially, it is possible to have POE
  enabled, and yet overlays disabled, while the converse isn't
  true

What this all means is that once the base permissions have been
established, checking for wi->{e0,}poe makes little sense, because
the truth about overlays resides in wr->{p,u}ov. So constructs
checking for (wi->poe && wr->pov) only add perplexity.

Refactor compute_s1_overlay_permissions() and the way it is
called according to the above principles. Take the opportunity
to avoid reading registers that are not strictly required.

Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20250701151648.754785-2-maz@kernel.org


Signed-off-by: default avatarOliver Upton <oliver.upton@linux.dev>
parent 4530256f

arch/arm64/kvm/at.c

+30 −22
Original line number Diff line number Diff line
@@ -1047,34 +1047,43 @@ static void compute_s1_overlay_permissions(struct kvm_vcpu *vcpu, 


	idx = FIELD_GET(PTE_PO_IDX_MASK, wr->desc);



	if (wr->pov) {

		switch (wi->regime) {

		case TR_EL10:

			pov_perms = perm_idx(vcpu, POR_EL1, idx);

		uov_perms = perm_idx(vcpu, POR_EL0, idx);

			break;

		case TR_EL20:

			pov_perms = perm_idx(vcpu, POR_EL2, idx);

		uov_perms = perm_idx(vcpu, POR_EL0, idx);

			break;

		case TR_EL2:

			pov_perms = perm_idx(vcpu, POR_EL2, idx);

		uov_perms = 0;

			break;

		}



		if (pov_perms & ~POE_RWX)

			pov_perms = POE_NONE;



	if (wi->poe && wr->pov) {

		wr->pr &= pov_perms & POE_R;

		wr->pw &= pov_perms & POE_W;

		wr->px &= pov_perms & POE_X;

	}



	if (wr->uov) {

		switch (wi->regime) {

		case TR_EL10:

			uov_perms = perm_idx(vcpu, POR_EL0, idx);

			break;

		case TR_EL20:

			uov_perms = perm_idx(vcpu, POR_EL0, idx);

			break;

		case TR_EL2:

			uov_perms = 0;

			break;

		}



		if (uov_perms & ~POE_RWX)

			uov_perms = POE_NONE;



	if (wi->e0poe && wr->uov) {

		wr->ur &= uov_perms & POE_R;

		wr->uw &= uov_perms & POE_W;

		wr->ux &= uov_perms & POE_X;
@@ -1095,7 +1104,6 @@ static void compute_s1_permissions(struct kvm_vcpu *vcpu, 
	if (!wi->hpd)

		compute_s1_hierarchical_permissions(vcpu, wi, wr);



	if (wi->poe || wi->e0poe)

	compute_s1_overlay_permissions(vcpu, wi, wr);



	/* R_QXXPC */