Commit a5393636 authored by Chao Yu's avatar Chao Yu Committed by Jaegeuk Kim
Browse files

f2fs: delete obsolete FI_FIRST_BLOCK_WRITTEN 



Commit 3c6c2beb ("f2fs: avoid punch_hole overhead when releasing
volatile data") introduced FI_FIRST_BLOCK_WRITTEN as below reason:

This patch is to avoid some punch_hole overhead when releasing volatile
data. If volatile data was not written yet, we just can make the first
page as zero.

After commit 7bc155fe ("f2fs: kill volatile write support"), we
won't support volatile write, but it missed to remove obsolete
FI_FIRST_BLOCK_WRITTEN, delete it in this patch.

Signed-off-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent a6a010f5

fs/f2fs/compress.c

+0 −2
Original line number Diff line number Diff line
@@ -1369,8 +1369,6 @@ static int f2fs_write_compressed_pages(struct compress_ctx *cc, 
	add_compr_block_stat(inode, cc->valid_nr_cpages);



	set_inode_flag(cc->inode, FI_APPEND_WRITE);

	if (cc->cluster_idx == 0)

		set_inode_flag(inode, FI_FIRST_BLOCK_WRITTEN);



	f2fs_put_dnode(&dn);

	if (quota_inode)

fs/f2fs/data.c

+0 −2
Original line number Diff line number Diff line
@@ -2810,8 +2810,6 @@ int f2fs_do_write_data_page(struct f2fs_io_info *fio) 
	f2fs_outplace_write_data(&dn, fio);

	trace_f2fs_do_write_data_page(page, OPU);

	set_inode_flag(inode, FI_APPEND_WRITE);

	if (page->index == 0)

		set_inode_flag(inode, FI_FIRST_BLOCK_WRITTEN);

out_writepage:

	f2fs_put_dnode(&dn);

out:

fs/f2fs/f2fs.h

+0 −6
Original line number Diff line number Diff line
@@ -781,7 +781,6 @@ enum { 
	FI_UPDATE_WRITE,	/* inode has in-place-update data */

	FI_NEED_IPU,		/* used for ipu per file */

	FI_ATOMIC_FILE,		/* indicate atomic file */

	FI_FIRST_BLOCK_WRITTEN,	/* indicate #0 data block was written */

	FI_DROP_CACHE,		/* drop dirty page cache */

	FI_DATA_EXIST,		/* indicate data exists */

	FI_INLINE_DOTS,		/* indicate inline dot dentries */
@@ -3279,11 +3278,6 @@ static inline bool f2fs_is_cow_file(struct inode *inode) 
	return is_inode_flag_set(inode, FI_COW_FILE);

}



static inline bool f2fs_is_first_block_written(struct inode *inode)

{

	return is_inode_flag_set(inode, FI_FIRST_BLOCK_WRITTEN);

}



static inline bool f2fs_is_drop_cache(struct inode *inode)

{

	return is_inode_flag_set(inode, FI_DROP_CACHE);

fs/f2fs/file.c

+0 −3
Original line number Diff line number Diff line
@@ -599,9 +599,6 @@ void f2fs_truncate_data_blocks_range(struct dnode_of_data *dn, int count) 
				valid_blocks++;

		}



		if (dn->ofs_in_node == 0 && IS_INODE(dn->node_page))

			clear_inode_flag(dn->inode, FI_FIRST_BLOCK_WRITTEN);



		f2fs_invalidate_blocks(sbi, blkaddr);



		if (!released || blkaddr != COMPRESS_ADDR)

fs/f2fs/gc.c

+0 −2
Original line number Diff line number Diff line
@@ -1405,8 +1405,6 @@ static int move_data_block(struct inode *inode, block_t bidx, 


	f2fs_update_data_blkaddr(&dn, newaddr);

	set_inode_flag(inode, FI_APPEND_WRITE);

	if (page->index == 0)

		set_inode_flag(inode, FI_FIRST_BLOCK_WRITTEN);

put_page_out:

	f2fs_put_page(fio.encrypted_page, 1);

recover_block: