Commit a541a6e8 authored by Yunxiang Li's avatar Yunxiang Li Committed by Christian König
Browse files

drm/amdgpu: remove unused function parameter 



amdgpu_vm_bo_invalidate doesn't use the adev parameter and not all
callers have a reference to adev handy, so remove it for cleanliness.

Signed-off-by: default avatarYunxiang Li <Yunxiang.Li@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241219151411.1150-5-Yunxiang.Li@amd.com


Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
parent e77d0401

drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

+2 −2
Original line number Diff line number Diff line
@@ -1105,7 +1105,7 @@ static int amdgpu_cs_vm_handling(struct amdgpu_cs_parser *p) 
	 * We can't use gang submit on with reserved VMIDs when the VM changes

	 * can't be invalidated by more than one engine at the same time.

	 */

	if (p->gang_size > 1 && !p->adev->vm_manager.concurrent_flush) {

	if (p->gang_size > 1 && !adev->vm_manager.concurrent_flush) {

		for (i = 0; i < p->gang_size; ++i) {

			struct drm_sched_entity *entity = p->entities[i];

			struct drm_gpu_scheduler *sched = entity->rq->sched;
@@ -1189,7 +1189,7 @@ static int amdgpu_cs_vm_handling(struct amdgpu_cs_parser *p) 
			if (!bo)

				continue;



			amdgpu_vm_bo_invalidate(adev, bo, false);

			amdgpu_vm_bo_invalidate(bo, false);

		}

	}

drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c

+1 −1
Original line number Diff line number Diff line
@@ -345,7 +345,7 @@ amdgpu_dma_buf_move_notify(struct dma_buf_attachment *attach) 
	/* FIXME: This should be after the "if", but needs a fix to make sure

	 * DMABuf imports are initialized in the right VM list.

	 */

	amdgpu_vm_bo_invalidate(adev, bo, false);

	amdgpu_vm_bo_invalidate(bo, false);

	if (!bo->tbo.resource || bo->tbo.resource->mem_type == TTM_PL_SYSTEM)

		return;

drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

+1 −2
Original line number Diff line number Diff line
@@ -839,7 +839,6 @@ int amdgpu_gem_va_ioctl(struct drm_device *dev, void *data, 
int amdgpu_gem_op_ioctl(struct drm_device *dev, void *data,

			struct drm_file *filp)

{

	struct amdgpu_device *adev = drm_to_adev(dev);

	struct drm_amdgpu_gem_op *args = data;

	struct drm_gem_object *gobj;

	struct amdgpu_vm_bo_base *base;
@@ -899,7 +898,7 @@ int amdgpu_gem_op_ioctl(struct drm_device *dev, void *data, 
			robj->allowed_domains |= AMDGPU_GEM_DOMAIN_GTT;



		if (robj->flags & AMDGPU_GEM_CREATE_VM_ALWAYS_VALID)

			amdgpu_vm_bo_invalidate(adev, robj, true);

			amdgpu_vm_bo_invalidate(robj, true);



		amdgpu_bo_unreserve(robj);

		break;

drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

+1 −2
Original line number Diff line number Diff line
@@ -1150,7 +1150,6 @@ void amdgpu_bo_move_notify(struct ttm_buffer_object *bo, 
			   bool evict,

			   struct ttm_resource *new_mem)

{

	struct amdgpu_device *adev = amdgpu_ttm_adev(bo->bdev);

	struct ttm_resource *old_mem = bo->resource;

	struct amdgpu_bo *abo;
@@ -1158,7 +1157,7 @@ void amdgpu_bo_move_notify(struct ttm_buffer_object *bo, 
		return;



	abo = ttm_to_amdgpu_bo(bo);

	amdgpu_vm_bo_invalidate(adev, abo, evict);

	amdgpu_vm_bo_invalidate(abo, evict);



	amdgpu_bo_kunmap(abo);

drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

+1 −3
Original line number Diff line number Diff line
@@ -2143,14 +2143,12 @@ bool amdgpu_vm_evictable(struct amdgpu_bo *bo) 
/**

 * amdgpu_vm_bo_invalidate - mark the bo as invalid

 *

 * @adev: amdgpu_device pointer

 * @bo: amdgpu buffer object

 * @evicted: is the BO evicted

 *

 * Mark @bo as invalid.

 */

void amdgpu_vm_bo_invalidate(struct amdgpu_device *adev,

			     struct amdgpu_bo *bo, bool evicted)

void amdgpu_vm_bo_invalidate(struct amdgpu_bo *bo, bool evicted)

{

	struct amdgpu_vm_bo_base *bo_base;