Commit a55ec9c8 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: stmmac: anarion: clean up interface parsing 



anarion_config_dt() used a switch statement to check for the RGMII
modes, complete with an unnecessary "fallthrough", and also printed
the numerical value of the PHY interface mode on error. Clean this
up using the phy_interface_mode_is_rgmii() helper, and print the
English version of the PHY interface mode on error.

Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1u4FlV-000XjG-83@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c30a45a7

drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c

+4 −10
Original line number Diff line number Diff line
@@ -79,17 +79,11 @@ anarion_config_dt(struct platform_device *pdev, 


	gmac->ctl_block = ctl_block;



	switch (plat_dat->phy_interface) {

	case PHY_INTERFACE_MODE_RGMII:

		fallthrough;

	case PHY_INTERFACE_MODE_RGMII_ID:

	case PHY_INTERFACE_MODE_RGMII_RXID:

	case PHY_INTERFACE_MODE_RGMII_TXID:

	if (phy_interface_mode_is_rgmii(plat_dat->phy_interface)) {

		gmac->phy_intf_sel = GMAC_CONFIG_INTF_RGMII;

		break;

	default:

		dev_err(&pdev->dev, "Unsupported phy-mode (%d)\n",

			plat_dat->phy_interface);

	} else {

		dev_err(&pdev->dev, "Unsupported phy-mode (%s)\n",

			phy_modes(plat_dat->phy_interface));

		return ERR_PTR(-ENOTSUPP);

	}