Commit a572593a authored by Bart Van Assche's avatar Bart Van Assche Committed by Song Liu
Browse files

md: Fix linear_set_limits() 



queue_limits_cancel_update() must only be called if
queue_limits_start_update() is called first. Remove the
queue_limits_cancel_update() call from linear_set_limits() because
there is no corresponding queue_limits_start_update() call.

This bug was discovered by annotating all mutex operations with clang
thread-safety attributes and by building the kernel with clang and
-Wthread-safety.

Cc: Yu Kuai <yukuai3@huawei.com>
Cc: Coly Li <colyli@kernel.org>
Cc: Mike Snitzer <snitzer@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Fixes: 127186cf ("md: reintroduce md-linear")
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20250129225636.2667932-1-bvanassche@acm.org


Signed-off-by: default avatarSong Liu <song@kernel.org>
parent 1e1a9cec

drivers/md/md-linear.c

+1 −3
Original line number Diff line number Diff line
@@ -76,10 +76,8 @@ static int linear_set_limits(struct mddev *mddev) 
	lim.max_write_zeroes_sectors = mddev->chunk_sectors;

	lim.io_min = mddev->chunk_sectors << 9;

	err = mddev_stack_rdev_limits(mddev, &lim, MDDEV_STACK_INTEGRITY);

	if (err) {

		queue_limits_cancel_update(mddev->gendisk->queue);

	if (err)

		return err;

	}



	return queue_limits_set(mddev->gendisk->queue, &lim);

}