Commit a576f369 authored by Aleksandr Aprelkov's avatar Aleksandr Aprelkov Committed by Chuck Lever
Browse files

sunrpc: removed redundant procp check 



since vs_proc pointer is dereferenced before getting it's address there's
no need to check for NULL.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 8e5b6773 ("SUNRPC: Add a callback to initialise server requests")
Signed-off-by: default avatarAleksandr Aprelkov <aaprelkov@usergate.com>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent 7d12cce8

net/sunrpc/svc.c

+0 −2
Original line number Diff line number Diff line
@@ -1265,8 +1265,6 @@ svc_generic_init_request(struct svc_rqst *rqstp, 
	if (rqstp->rq_proc >= versp->vs_nproc)

		goto err_bad_proc;

	rqstp->rq_procinfo = procp = &versp->vs_proc[rqstp->rq_proc];

	if (!procp)

		goto err_bad_proc;



	/* Initialize storage for argp and resp */

	memset(rqstp->rq_argp, 0, procp->pc_argzero);