Commit a58501fb authored by Phil Auld's avatar Phil Auld Committed by Peter Zijlstra
Browse files

sched: remove HZ_BW feature hedge 



As a hedge against unexpected user issues commit 88c56cfe
("sched/fair: Block nohz tick_stop when cfs bandwidth in use")
included a scheduler feature to disable the new functionality.
It's been a few releases (v6.6) and no screams, so remove it.

Signed-off-by: default avatarPhil Auld <pauld@redhat.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarValentin Schneider <vschneid@redhat.com>
Link: https://lore.kernel.org/r/20240515133705.3632915-1-pauld@redhat.com
parent 2c2d9624

kernel/sched/core.c

+1 −1
Original line number Diff line number Diff line
@@ -1269,7 +1269,7 @@ bool sched_can_stop_tick(struct rq *rq) 
	 * dequeued by migrating while the constrained task continues to run.

	 * E.g. going from 2->1 without going through pick_next_task().

	 */

	if (sched_feat(HZ_BW) && __need_bw_check(rq, rq->curr)) {

	if (__need_bw_check(rq, rq->curr)) {

		if (cfs_task_bw_constrained(rq->curr))

			return false;

	}

kernel/sched/fair.c

+1 −1
Original line number Diff line number Diff line
@@ -6555,7 +6555,7 @@ static void sched_fair_update_stop_tick(struct rq *rq, struct task_struct *p) 
{

	int cpu = cpu_of(rq);



	if (!sched_feat(HZ_BW) || !cfs_bandwidth_used())

	if (!cfs_bandwidth_used())

		return;



	if (!tick_nohz_full_cpu(cpu))

kernel/sched/features.h

+0 −2
Original line number Diff line number Diff line
@@ -85,5 +85,3 @@ SCHED_FEAT(WA_BIAS, true) 
SCHED_FEAT(UTIL_EST, true)



SCHED_FEAT(LATENCY_WARN, false)
 


SCHED_FEAT(HZ_BW, true)