Commit a5a50f14 authored by Shyam Prasad N's avatar Shyam Prasad N Committed by Steve French
Browse files

cifs: remove unnecessary tracing after put tcon 



This code was recently changed from manually decrementing
tcon ref to using cifs_put_tcon. But even before that change
this tracing happened after decrementing the ref count, which
is wrong. With cifs_put_tcon, tracing already happens inside it.
So just removing the extra tracing here.

Signed-off-by: default avatarShyam Prasad N <sprasad@microsoft.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 8e61cfc5

fs/smb/client/smb2ops.c

+0 −2
Original line number Diff line number Diff line
@@ -3181,8 +3181,6 @@ smb2_get_dfs_refer(const unsigned int xid, struct cifs_ses *ses, 
	if (tcon && !tcon->ipc) {

		/* ipc tcons are not refcounted */

		cifs_put_tcon(tcon, netfs_trace_tcon_ref_put_dfs_refer);

		trace_smb3_tcon_ref(tcon->debug_id, tcon->tc_count,

				    netfs_trace_tcon_ref_dec_dfs_refer);

	}

	kfree(utf16_path);

	kfree(dfs_req);

fs/smb/client/trace.h

+0 −1
Original line number Diff line number Diff line
@@ -168,7 +168,6 @@ 
	E_(cifs_trace_rw_credits_zero_in_flight,	"ZERO-IN-FLT")



#define smb3_tcon_ref_traces					      \

	EM(netfs_trace_tcon_ref_dec_dfs_refer,		"DEC DfsRef") \

	EM(netfs_trace_tcon_ref_free,			"FRE       ") \

	EM(netfs_trace_tcon_ref_free_fail,		"FRE Fail  ") \

	EM(netfs_trace_tcon_ref_free_ipc,		"FRE Ipc   ") \