Commit a5bb8a64 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/tcx: Use initializer macro for struct fb_ops 



Initialize struct fb_ops to the correct default values with the
macro FB_DEFAULT_SBUS_OPS(). Rename the ioctl and mmap callbacks
to use the infix _sbusfb_. This makes them fit the SBUS helpers'
naming pattern. Also make the driver depend on FB_SBUS_HELPERS,
which selects the correct modules.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230806120926.5368-12-tzimmermann@suse.de
parent d1ed0f1d

drivers/video/fbdev/Kconfig

+1 −3
Original line number Diff line number Diff line
@@ -559,9 +559,7 @@ config FB_FFB 
config FB_TCX

	bool "TCX (SS4/SS5 only) support"

	depends on FB_SBUS

	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT

	select FB_SBUS_HELPERS

	help

	  This is the frame buffer device driver for the TCX 24/8bit frame

	  buffer.

drivers/video/fbdev/tcx.c

+6 −14
Original line number Diff line number Diff line
@@ -31,28 +31,21 @@ 
static int tcx_setcolreg(unsigned, unsigned, unsigned, unsigned,

			 unsigned, struct fb_info *);

static int tcx_blank(int, struct fb_info *);



static int tcx_mmap(struct fb_info *, struct vm_area_struct *);

static int tcx_ioctl(struct fb_info *, unsigned int, unsigned long);

static int tcx_pan_display(struct fb_var_screeninfo *, struct fb_info *);



static int tcx_sbusfb_mmap(struct fb_info *info, struct vm_area_struct *vma);

static int tcx_sbusfb_ioctl(struct fb_info *info, unsigned int cmd, unsigned long arg);



/*

 *  Frame buffer operations

 */



static const struct fb_ops tcx_ops = {

	.owner			= THIS_MODULE,

	FB_DEFAULT_SBUS_OPS(tcx),

	.fb_setcolreg		= tcx_setcolreg,

	.fb_blank		= tcx_blank,

	.fb_pan_display		= tcx_pan_display,

	.fb_fillrect		= cfb_fillrect,

	.fb_copyarea		= cfb_copyarea,

	.fb_imageblit		= cfb_imageblit,

	.fb_mmap		= tcx_mmap,

	.fb_ioctl		= tcx_ioctl,

#ifdef CONFIG_COMPAT

	.fb_compat_ioctl	= sbusfb_compat_ioctl,

#endif

};



/* THC definitions */
@@ -298,7 +291,7 @@ static struct sbus_mmap_map __tcx_mmap_map[TCX_MMAP_ENTRIES] = { 
	{ .size = 0 }

};



static int tcx_mmap(struct fb_info *info, struct vm_area_struct *vma)

static int tcx_sbusfb_mmap(struct fb_info *info, struct vm_area_struct *vma)

{

	struct tcx_par *par = (struct tcx_par *)info->par;
@@ -307,8 +300,7 @@ static int tcx_mmap(struct fb_info *info, struct vm_area_struct *vma) 
				  par->which_io, vma);

}



static int tcx_ioctl(struct fb_info *info, unsigned int cmd,

		     unsigned long arg)

static int tcx_sbusfb_ioctl(struct fb_info *info, unsigned int cmd, unsigned long arg)

{

	struct tcx_par *par = (struct tcx_par *) info->par;