Commit a5d1d0a1 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915/sdvo: Protect macro args 



Put parens around macro argument evaluation for safety.

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230705202122.17915-3-ville.syrjala@linux.intel.com


Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
parent 1d6f7b19

drivers/gpu/drm/i915/display/intel_sdvo.c

+7 −8
Original line number Diff line number Diff line
@@ -57,14 +57,13 @@ 
#define SDVO_LVDS_MASK (SDVO_OUTPUT_LVDS0 | SDVO_OUTPUT_LVDS1)

#define SDVO_TV_MASK   (SDVO_OUTPUT_CVBS0 | SDVO_OUTPUT_SVID0 | SDVO_OUTPUT_YPRPB0)



#define SDVO_OUTPUT_MASK (SDVO_TMDS_MASK | SDVO_RGB_MASK | SDVO_LVDS_MASK |\

			SDVO_TV_MASK)



#define IS_TV(c)	(c->output_flag & SDVO_TV_MASK)

#define IS_TMDS(c)	(c->output_flag & SDVO_TMDS_MASK)

#define IS_LVDS(c)	(c->output_flag & SDVO_LVDS_MASK)

#define IS_TV_OR_LVDS(c) (c->output_flag & (SDVO_TV_MASK | SDVO_LVDS_MASK))

#define IS_DIGITAL(c) (c->output_flag & (SDVO_TMDS_MASK | SDVO_LVDS_MASK))

#define SDVO_OUTPUT_MASK (SDVO_TMDS_MASK | SDVO_RGB_MASK | SDVO_LVDS_MASK | SDVO_TV_MASK)



#define IS_TV(c)		((c)->output_flag & SDVO_TV_MASK)

#define IS_TMDS(c)		((c)->output_flag & SDVO_TMDS_MASK)

#define IS_LVDS(c)		((c)->output_flag & SDVO_LVDS_MASK)

#define IS_TV_OR_LVDS(c)	((c)->output_flag & (SDVO_TV_MASK | SDVO_LVDS_MASK))

#define IS_DIGITAL(c)		((c)->output_flag & (SDVO_TMDS_MASK | SDVO_LVDS_MASK))





static const char * const tv_format_names[] = {