Commit a628f667 authored by Chuck Lever's avatar Chuck Lever Committed by J. Bruce Fields
Browse files

NFSD: Fix mixed sign comparison in nfs3svc_decode_symlinkargs 



Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Acked-By: default avatarNeilBrown <neilb@suse.de>
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
parent 9c7544d3

fs/nfsd/nfs3xdr.c

+3 −3
Original line number Diff line number Diff line
@@ -452,8 +452,7 @@ int 
nfs3svc_decode_symlinkargs(struct svc_rqst *rqstp, __be32 *p,

					struct nfsd3_symlinkargs *args)

{

	unsigned int len;

	int avail;

	unsigned int len, avail;

	char *old, *new;

	struct kvec *vec;
@@ -486,7 +485,8 @@ nfs3svc_decode_symlinkargs(struct svc_rqst *rqstp, __be32 *p, 
	/* now copy next page if there is one */

	if (len && !avail && rqstp->rq_arg.page_len) {

		avail = rqstp->rq_arg.page_len;

		if (avail > PAGE_SIZE) avail = PAGE_SIZE;

		if (avail > PAGE_SIZE)

			avail = PAGE_SIZE;

		old = page_address(rqstp->rq_arg.pages[0]);

	}

	while (len && avail && *old) {