Commit a630f835 authored by Lama Kayal's avatar Lama Kayal Committed by Jakub Kicinski
Browse files

net/mlx5: HWS, Fix memory leak in hws_action_get_shared_stc_nic error flow 



When an invalid stc_type is provided, the function allocates memory for
shared_stc but jumps to unlock_and_out without freeing it, causing a
memory leak.

Fix by jumping to free_shared_stc label instead to ensure proper cleanup.

Fixes: 504e536d ("net/mlx5: HWS, added actions handling")
Signed-off-by: default avatarLama Kayal <lkayal@nvidia.com>
Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Signed-off-by: default avatarMark Bloch <mbloch@nvidia.com>
Link: https://patch.msgid.link/20250825143435.598584-3-mbloch@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 2c0a959b

drivers/net/ethernet/mellanox/mlx5/core/steering/hws/action.c

+1 −1
Original line number Diff line number Diff line
@@ -117,7 +117,7 @@ static int hws_action_get_shared_stc_nic(struct mlx5hws_context *ctx, 
		mlx5hws_err(ctx, "No such stc_type: %d\n", stc_type);

		pr_warn("HWS: Invalid stc_type: %d\n", stc_type);

		ret = -EINVAL;

		goto unlock_and_out;

		goto free_shared_stc;

	}



	ret = mlx5hws_action_alloc_single_stc(ctx, &stc_attr, tbl_type,