Commit a63bb695 authored by Brett Creeley's avatar Brett Creeley Committed by Jakub Kicinski
Browse files

ionic: remove the unused nb_work 

Remove the empty and unused nb_work and associated
ionic_lif_notify_work() function.

v2: separated from previous net patch

Link: https://lore.kernel.org/netdev/20241210174828.69525-2-shannon.nelson@amd.com/


Signed-off-by: default avatarBrett Creeley <brett.creeley@amd.com>
Signed-off-by: default avatarShannon Nelson <shannon.nelson@amd.com>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Reviewed-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Link: https://patch.msgid.link/20241212212042.9348-1-shannon.nelson@amd.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0193eebb

drivers/net/ethernet/pensando/ionic/ionic.h

+0 −1
Original line number Diff line number Diff line
@@ -57,7 +57,6 @@ struct ionic { 
	DECLARE_BITMAP(intrs, IONIC_INTR_CTRL_REGS_MAX);

	cpumask_var_t *affinity_masks;

	struct delayed_work doorbell_check_dwork;

	struct work_struct nb_work;

	struct notifier_block nb;

	struct rw_semaphore vf_op_lock;	/* lock for VF operations */

	struct ionic_vf *vfs;

drivers/net/ethernet/pensando/ionic/ionic_lif.c

+0 −7
Original line number Diff line number Diff line
@@ -3804,10 +3804,6 @@ int ionic_lif_init(struct ionic_lif *lif) 
	return err;

}



static void ionic_lif_notify_work(struct work_struct *ws)

{

}



static void ionic_lif_set_netdev_info(struct ionic_lif *lif)

{

	struct ionic_admin_ctx ctx = {
@@ -3858,8 +3854,6 @@ int ionic_lif_register(struct ionic_lif *lif) 


	ionic_lif_register_phc(lif);



	INIT_WORK(&lif->ionic->nb_work, ionic_lif_notify_work);



	lif->ionic->nb.notifier_call = ionic_lif_notify;



	err = register_netdevice_notifier(&lif->ionic->nb);
@@ -3885,7 +3879,6 @@ void ionic_lif_unregister(struct ionic_lif *lif) 
{

	if (lif->ionic->nb.notifier_call) {

		unregister_netdevice_notifier(&lif->ionic->nb);

		cancel_work_sync(&lif->ionic->nb_work);

		lif->ionic->nb.notifier_call = NULL;

	}