Commit a643abb6 authored by Liao Yuanhong's avatar Liao Yuanhong Committed by Dmitry Baryshkov
Browse files

drm/msm/mdp4: remove the use of dev_err_probe() 

Logging messages that show some type of "out of memory" error are generally
unnecessary as there is a generic message and a stack dump done by the
memory subsystem. These messages generally increase kernel size without
much added value[1].

The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
remove the useless call to dev_err_probe(), and just return the value
instead.

[1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/



Signed-off-by: default avatarLiao Yuanhong <liaoyuanhong@vivo.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/670017/
Link: https://lore.kernel.org/r/20250820131300.499727-1-liaoyuanhong@vivo.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
parent 88ec0e01

drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c

+1 −1
Original line number Diff line number Diff line
@@ -512,7 +512,7 @@ static int mdp4_probe(struct platform_device *pdev) 


	mdp4_kms = devm_kzalloc(dev, sizeof(*mdp4_kms), GFP_KERNEL);

	if (!mdp4_kms)

		return dev_err_probe(dev, -ENOMEM, "failed to allocate kms\n");

		return -ENOMEM;



	mdp4_kms->mmio = msm_ioremap(pdev, NULL);

	if (IS_ERR(mdp4_kms->mmio))