Unverified Commit a69997be authored by Liao Yuanhong's avatar Liao Yuanhong Committed by Javier Martinez Canillas
Browse files

drm/ssd130x: Remove the use of dev_err_probe() 

Logging messages that show some type of "out of memory" error are generally
unnecessary as there is a generic message and a stack dump done by the
memory subsystem. These messages generally increase kernel size without
much added value[1].

The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
remove the useless call to dev_err_probe(), and just return the value
instead.

[1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/



Signed-off-by: default avatarLiao Yuanhong <liaoyuanhong@vivo.com>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Link: https://lore.kernel.org/r/20250820131416.500048-1-liaoyuanhong@vivo.com


Signed-off-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
parent 100d457c

drivers/gpu/drm/solomon/ssd130x-spi.c

+1 −2
Original line number Diff line number Diff line
@@ -74,8 +74,7 @@ static int ssd130x_spi_probe(struct spi_device *spi) 


	t = devm_kzalloc(dev, sizeof(*t), GFP_KERNEL);

	if (!t)

		return dev_err_probe(dev, -ENOMEM,

				     "Failed to allocate SPI transport data\n");

		return -ENOMEM;



	t->spi = spi;

	t->dc = dc;