Commit a6a2f50a authored by Yulin Lu's avatar Yulin Lu Committed by Linus Walleij
Browse files

pinctrl: eswin: Fix regulator error check and Kconfig dependency 



Smatch reported the following warning in eic7700_pinctrl_probe():

  drivers/pinctrl/pinctrl-eic7700.c:638 eic7700_pinctrl_probe()
  warn: passing zero to 'PTR_ERR'

The root cause is that devm_regulator_get() may return NULL when
CONFIG_REGULATOR is disabled. In such case, IS_ERR_OR_NULL() triggers
PTR_ERR(NULL) which evaluates to 0, leading to passing a success code
as an error.

However, this driver cannot work without a regulator. To fix this:

 - Change the check from IS_ERR_OR_NULL() to IS_ERR()
 - Update Kconfig to explicitly select REGULATOR and
   REGULATOR_FIXED_VOLTAGE, ensuring that the regulator framework is
   always available.

This resolves the Smatch warning and enforces the correct dependency.

Suggested-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Fixes: 5b797bcc ("pinctrl: eswin: Add EIC7700 pinctrl driver")
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-gpio/aKRGiZ-fai0bv0tG@stanley.mountain/


Signed-off-by: default avatarYulin Lu <luyulin@eswincomputing.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 657cbf9b

drivers/pinctrl/Kconfig

+2 −0
Original line number Diff line number Diff line
@@ -211,6 +211,8 @@ config PINCTRL_EIC7700 
	depends on ARCH_ESWIN || COMPILE_TEST

	select PINMUX

	select GENERIC_PINCONF

	select REGULATOR

	select REGULATOR_FIXED_VOLTAGE

	help

	  This driver support for the pin controller in ESWIN's EIC7700 SoC,

	  which supports pin multiplexing, pin configuration,and rgmii voltage

drivers/pinctrl/pinctrl-eic7700.c

+1 −1
Original line number Diff line number Diff line
@@ -634,7 +634,7 @@ static int eic7700_pinctrl_probe(struct platform_device *pdev) 
		return PTR_ERR(pc->base);



	regulator = devm_regulator_get(dev, "vrgmii");

	if (IS_ERR_OR_NULL(regulator)) {

	if (IS_ERR(regulator)) {

		return dev_err_probe(dev, PTR_ERR(regulator),

					 "failed to get vrgmii regulator\n");

	}