Commit a6a9a5da authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Joerg Roedel
Browse files

iommu: Fix refcount leak in iommu_device_claim_dma_owner 



iommu_group_get() returns the group with the reference incremented.
Move iommu_group_get() after owner check to fix the refcount leak.

Fixes: 89395cce ("iommu: Add device-centric DMA ownership interfaces")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20221230083100.1489569-1-linmq006@gmail.com


[ joro: Remove *group = NULL initialization ]
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 32ea2c57

drivers/iommu/iommu.c

+5 −3
Original line number Diff line number Diff line
@@ -3185,14 +3185,16 @@ EXPORT_SYMBOL_GPL(iommu_group_claim_dma_owner); 
 */

int iommu_device_claim_dma_owner(struct device *dev, void *owner)

{

	struct iommu_group *group = iommu_group_get(dev);

	struct iommu_group *group;

	int ret = 0;



	if (!group)

		return -ENODEV;

	if (WARN_ON(!owner))

		return -EINVAL;



	group = iommu_group_get(dev);

	if (!group)

		return -ENODEV;



	mutex_lock(&group->mutex);

	if (group->owner_cnt) {

		if (group->owner != owner) {