Unverified Commit a6b9f5b2 authored by Breno Leitao's avatar Breno Leitao Committed by Christian Brauner
Browse files

fs/namei: Remove redundant DCACHE_MANAGED_DENTRY check in __follow_mount_rcu 



The check for DCACHE_MANAGED_DENTRY at the start of __follow_mount_rcu()
is redundant because the only caller (handle_mounts) already verifies
d_managed(dentry) before calling this function, so, dentry in
__follow_mount_rcu() has always DCACHE_MANAGED_DENTRY set.

This early-out optimization never fires in practice - but it is marking
as likely().

This was detected with branch profiling, which shows 100% misprediction
in this likely.

Remove the whole if clause instead of removing the likely, given we
know for sure that dentry is not DCACHE_MANAGED_DENTRY.

Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20260105-dcache-v1-1-f0d904b4a7c2@debian.org


Acked-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 729d015a

fs/namei.c

+0 −3
Original line number Diff line number Diff line
@@ -1624,9 +1624,6 @@ static bool __follow_mount_rcu(struct nameidata *nd, struct path *path) 
	struct dentry *dentry = path->dentry;

	unsigned int flags = dentry->d_flags;



	if (likely(!(flags & DCACHE_MANAGED_DENTRY)))

		return true;



	if (unlikely(nd->flags & LOOKUP_NO_XDEV))

		return false;