Commit a6ca7e62 authored by Javier Carrasco's avatar Javier Carrasco Committed by Geert Uytterhoeven
Browse files

clk: renesas: cpg-mssr: Fix 'soc' node handling in cpg_mssr_reserved_init() 



A device_node reference obtained via of_find_node_by_path() requires
explicit calls to of_node_put() after it is no longer required to avoid
leaking the resource.

Instead of adding the missing calls to of_node_put() in all execution
paths, use the cleanup attribute for 'soc' by means of the __free()
macro, which automatically calls of_node_put() when the variable goes
out of scope.

Fixes: 6aa17547 ("clk: renesas: cpg-mssr: Ignore all clocks assigned to non-Linux system")
Signed-off-by: default avatarJavier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/20241031-clk-renesas-cpg-mssr-cleanup-v2-1-0010936d1154@gmail.com


Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
parent 40384c84

drivers/clk/renesas/renesas-cpg-mssr.c

+1 −1
Original line number Diff line number Diff line
@@ -979,7 +979,7 @@ static void __init cpg_mssr_reserved_exit(struct cpg_mssr_priv *priv) 
static int __init cpg_mssr_reserved_init(struct cpg_mssr_priv *priv,

					 const struct cpg_mssr_info *info)

{

	struct device_node *soc = of_find_node_by_path("/soc");

	struct device_node *soc __free(device_node) = of_find_node_by_path("/soc");

	struct device_node *node;

	uint32_t args[MAX_PHANDLE_ARGS];

	unsigned int *ids = NULL;