Commit a6d05e82 authored by Luca Ceresoli's avatar Luca Ceresoli Committed by Andrew Morton
Browse files

scripts/decode_stacktrace.sh: clarify command line 

The syntax as expressed by usage() is not entirely correct: "<modules
path>" cannot be passed without "<base path>|auto".  Additionally human
reading of this syntax can be subject to misunderstanding due the mixture
of '|' and '[]'.

Improve readability in various ways:
 * rewrite using two lines for the two allowed usages
 * add square brackets around "<vmlinux>" as it is optional when using
   debuginfod-find
 * move "<modules path>" to inside the square brackets of the 2nd
   positional parameter
 * use underscores instead of spaces in <...> strings

Link: https://lkml.kernel.org/r/20240823-decode_stacktrace-find_module-improvements-v2-2-d7a57d35558b@bootlin.com


Signed-off-by: default avatarLuca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: default avatarStephen Boyd <swboyd@chromium.org>
Cc: Alexis Lothoré (eBPF Foundation) <alexis.lothore@bootlin.com>
Cc: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 0f69dc29

scripts/decode_stacktrace.sh

+2 −1
Original line number Diff line number Diff line
@@ -5,7 +5,8 @@ 


usage() {

	echo "Usage:"

	echo "	$0 -r <release> | <vmlinux> [<base path>|auto] [<modules path>]"

	echo "	$0 -r <release>"

	echo "	$0 [<vmlinux> [<base_path>|auto [<modules_path>]]]"

}



# Try to find a Rust demangler