Commit a729c166 authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Bjorn Helgaas
Browse files

PCI: qcom: Remove custom ASPM enablement code 



Since the PCI subsystem has started enabling all ASPM states for all
devicetree based platforms, the ASPM enablement code from this driver can
now be dropped.

Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Link: https://patch.msgid.link/20250922-pci-dt-aspm-v2-2-2a65cf84e326@oss.qualcomm.com
parent f3ac2ff1

drivers/pci/controller/dwc/pcie-qcom.c

+0 −32
Original line number Diff line number Diff line
@@ -247,7 +247,6 @@ struct qcom_pcie_ops { 
	int (*get_resources)(struct qcom_pcie *pcie);

	int (*init)(struct qcom_pcie *pcie);

	int (*post_init)(struct qcom_pcie *pcie);

	void (*host_post_init)(struct qcom_pcie *pcie);

	void (*deinit)(struct qcom_pcie *pcie);

	void (*ltssm_enable)(struct qcom_pcie *pcie);

	int (*config_sid)(struct qcom_pcie *pcie);
@@ -1040,25 +1039,6 @@ static int qcom_pcie_post_init_2_7_0(struct qcom_pcie *pcie) 
	return 0;

}



static int qcom_pcie_enable_aspm(struct pci_dev *pdev, void *userdata)

{

	/*

	 * Downstream devices need to be in D0 state before enabling PCI PM

	 * substates.

	 */

	pci_set_power_state_locked(pdev, PCI_D0);

	pci_enable_link_state_locked(pdev, PCIE_LINK_STATE_ALL);



	return 0;

}



static void qcom_pcie_host_post_init_2_7_0(struct qcom_pcie *pcie)

{

	struct dw_pcie_rp *pp = &pcie->pci->pp;



	pci_walk_bus(pp->bridge->bus, qcom_pcie_enable_aspm, NULL);

}



static void qcom_pcie_deinit_2_7_0(struct qcom_pcie *pcie)

{

	struct qcom_pcie_resources_2_7_0 *res = &pcie->res.v2_7_0;
@@ -1358,19 +1338,9 @@ static void qcom_pcie_host_deinit(struct dw_pcie_rp *pp) 
	pcie->cfg->ops->deinit(pcie);

}



static void qcom_pcie_host_post_init(struct dw_pcie_rp *pp)

{

	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);

	struct qcom_pcie *pcie = to_qcom_pcie(pci);



	if (pcie->cfg->ops->host_post_init)

		pcie->cfg->ops->host_post_init(pcie);

}



static const struct dw_pcie_host_ops qcom_pcie_dw_ops = {

	.init		= qcom_pcie_host_init,

	.deinit		= qcom_pcie_host_deinit,

	.post_init	= qcom_pcie_host_post_init,

};



/* Qcom IP rev.: 2.1.0	Synopsys IP rev.: 4.01a */
@@ -1432,7 +1402,6 @@ static const struct qcom_pcie_ops ops_1_9_0 = { 
	.get_resources = qcom_pcie_get_resources_2_7_0,

	.init = qcom_pcie_init_2_7_0,

	.post_init = qcom_pcie_post_init_2_7_0,

	.host_post_init = qcom_pcie_host_post_init_2_7_0,

	.deinit = qcom_pcie_deinit_2_7_0,

	.ltssm_enable = qcom_pcie_2_3_2_ltssm_enable,

	.config_sid = qcom_pcie_config_sid_1_9_0,
@@ -1443,7 +1412,6 @@ static const struct qcom_pcie_ops ops_1_21_0 = { 
	.get_resources = qcom_pcie_get_resources_2_7_0,

	.init = qcom_pcie_init_2_7_0,

	.post_init = qcom_pcie_post_init_2_7_0,

	.host_post_init = qcom_pcie_host_post_init_2_7_0,

	.deinit = qcom_pcie_deinit_2_7_0,

	.ltssm_enable = qcom_pcie_2_3_2_ltssm_enable,

};