Commit a74b6c0e authored by David Gow's avatar David Gow Committed by Johannes Berg
Browse files

um: Don't rename vmap to kernel_vmap 



In order to work around the existence of a vmap symbol in libpcap, the
UML makefile unconditionally redefines vmap to kernel_vmap. However,
this not only affects the actual vmap symbol, but also anything else
named vmap, including a number of struct members in DRM.

This would not be too much of a problem, since all uses are also
updated, except we now have Rust DRM bindings, which expect the
corresponding Rust structs to have 'vmap' names. Since the redefinition
applies in bindgen, but not to Rust code, we end up with errors such as:

error[E0560]: struct `drm_gem_object_funcs` has no fields named `vmap`
  --> rust/kernel/drm/gem/mod.rs:210:9

Since libpcap support was removed in commit 12b8e7e6 ("um: Remove
obsolete pcap driver"), remove the, now unnecessary, define as well.

We also take this opportunity to update the comment.

Signed-off-by: default avatarDavid Gow <davidgow@google.com>
Acked-by: default avatarMiguel Ojeda <ojeda@kernel.org>
Link: https://patch.msgid.link/20251122083213.3996586-1-davidgow@google.com


Fixes: 12b8e7e6 ("um: Remove obsolete pcap driver")
[adjust commmit message a bit]
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 54618003

arch/um/Makefile

+5 −7
Original line number Diff line number Diff line
@@ -46,19 +46,17 @@ ARCH_INCLUDE := -I$(srctree)/$(SHARED_HEADERS) 
ARCH_INCLUDE	+= -I$(srctree)/$(HOST_DIR)/um/shared

KBUILD_CPPFLAGS += -I$(srctree)/$(HOST_DIR)/um



# -Dvmap=kernel_vmap prevents anything from referencing the libpcap.o symbol so

# named - it's a common symbol in libpcap, so we get a binary which crashes.

#

# Same things for in6addr_loopback and mktime - found in libc. For these two we

# only get link-time error, luckily.

# -Dstrrchr=kernel_strrchr (as well as the various in6addr symbols) prevents

#  anything from referencing

# libc symbols with the same name, which can cause a linker error.

#

# -Dlongjmp=kernel_longjmp prevents anything from referencing the libpthread.a

# embedded copy of longjmp, same thing for setjmp.

#

# These apply to USER_CFLAGS to.

# These apply to USER_CFLAGS too.



KBUILD_CFLAGS += $(CFLAGS) $(CFLAGS-y) -D__arch_um__ \

	$(ARCH_INCLUDE) $(MODE_INCLUDE) -Dvmap=kernel_vmap	\

	$(ARCH_INCLUDE) $(MODE_INCLUDE)	\

	-Dlongjmp=kernel_longjmp -Dsetjmp=kernel_setjmp \

	-Din6addr_loopback=kernel_in6addr_loopback \

	-Din6addr_any=kernel_in6addr_any -Dstrrchr=kernel_strrchr \