Commit a74c7a58 authored by Maxime Chevallier's avatar Maxime Chevallier Committed by Jakub Kicinski
Browse files

net: freescale: ucc_geth: Return early when TBI PHY can't be found 



In ucc_geth's .mac_config(), we configure the TBI Serdes block represented by a
struct phy_device that we get from firmware.

While porting to phylink, a check was missed to make sure we don't try
to access the TBI PHY if we can't get it. Let's add it and return early
in case of error

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202601130843.rFGNXA5a-lkp@intel.com/


Fixes: 53036aa8 ("net: freescale: ucc_geth: phylink conversion")
Signed-off-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://patch.msgid.link/20260114080247.366252-1-maxime.chevallier@bootlin.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 2c68d5ea

drivers/net/ethernet/freescale/ucc_geth.c

+3 −1
Original line number Diff line number Diff line
@@ -1602,8 +1602,10 @@ static void ugeth_mac_config(struct phylink_config *config, unsigned int mode, 
			pr_warn("TBI mode requires that the device tree specify a tbi-handle\n");



		tbiphy = of_phy_find_device(ug_info->tbi_node);

		if (!tbiphy)

		if (!tbiphy) {

			pr_warn("Could not get TBI device\n");

			return;

		}



		value = phy_read(tbiphy, ENET_TBI_MII_CR);

		value &= ~0x1000;	/* Turn off autonegotiation */