Commit a7540122 authored by Keith Busch's avatar Keith Busch Committed by Christoph Hellwig
Browse files

nvme-pci: fix queue unquiesce check on slot_reset 



A zero return means the reset was successfully scheduled. We don't want
to unquiesce the queues while the reset_work is pending, as that will
just flush out requeued requests to a failed completion.

Fixes: 71a5bb15 ("nvme: ensure disabling pairs with unquiesce")
Reported-by: default avatarDhankaran Singh Ajravat <dhankaran@meta.com>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent a584b263

drivers/nvme/host/pci.c

+1 −1
Original line number Diff line number Diff line
@@ -3575,7 +3575,7 @@ static pci_ers_result_t nvme_slot_reset(struct pci_dev *pdev) 


	dev_info(dev->ctrl.device, "restart after slot reset\n");

	pci_restore_state(pdev);

	if (!nvme_try_sched_reset(&dev->ctrl))

	if (nvme_try_sched_reset(&dev->ctrl))

		nvme_unquiesce_io_queues(&dev->ctrl);

	return PCI_ERS_RESULT_RECOVERED;

}