Commit a767957e authored by Jiasheng Jiang's avatar Jiasheng Jiang Committed by Jakub Kicinski
Browse files

ptp: ocp: Fix typo using index 1 instead of i in SMA initialization loop 



In ptp_ocp_sma_fb_init(), the code mistakenly used bp->sma[1]
instead of bp->sma[i] inside a for-loop, which caused only SMA[1]
to have its DIRECTION_CAN_CHANGE capability cleared. This led to
inconsistent capability flags across SMA pins.

Fixes: 09eeb3ae ("ptp_ocp: implement DPLL ops")
Signed-off-by: default avatarJiasheng Jiang <jiashengjiangcool@gmail.com>
Reviewed-by: default avatarVadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20251021182456.9729-1-jiashengjiangcool@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 4c3aa496

drivers/ptp/ptp_ocp.c

+1 −1
Original line number Diff line number Diff line
@@ -2548,7 +2548,7 @@ ptp_ocp_sma_fb_init(struct ptp_ocp *bp) 
		for (i = 0; i < OCP_SMA_NUM; i++) {

			bp->sma[i].fixed_fcn = true;

			bp->sma[i].fixed_dir = true;

			bp->sma[1].dpll_prop.capabilities &=

			bp->sma[i].dpll_prop.capabilities &=

				~DPLL_PIN_CAPABILITIES_DIRECTION_CAN_CHANGE;

		}

		return;